add tidb permit host option #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
1 similar comment
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
|
tennix
reviewed
Aug 16, 2019
charts/tidb-cluster/templates/scripts/_initialize_tidb_users.py.tpl
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tennix <[email protected]>
move permitHost after passwordSecretName
…y.tpl Co-Authored-By: Tennix <[email protected]>
|
/run-e2e-in-kind |
fix default permit host quote
|
/run-e2e-in-kind |
weekface
previously approved these changes
Aug 22, 2019
|
@shonge The e2e failed, can't set password to the tidb cluster PTAL |
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
1 similar comment
|
/run-e2e-in-kind |
cofyc
reviewed
Sep 3, 2019
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
weekface
approved these changes
Sep 9, 2019
|
cherry pick to release-1.0 in PR #893 |
|
Thanks for your contribution! |
cofyc
pushed a commit
that referenced
this pull request
Sep 9, 2019
* add grant permit host option. * fixed "Can't find any matching in user table" * add permitHost trigger to job.yaml * Update charts/tidb-cluster/values.yaml Co-Authored-By: Tennix <[email protected]> * Update tidb-initializer-job.yaml move permitHost after passwordSecretName * Update charts/tidb-cluster/templates/scripts/_initialize_tidb_users.py.tpl Co-Authored-By: Tennix <[email protected]> * Update _initialize_tidb_users.py.tpl * Update _initialize_tidb_users.py.tpl fix default permit host quote * fix access denied for root when executing initsql. * delete two duplicate commit lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#733
What is changed and how does it work?
Add an option permitHost in values, and add the logic in _initialize_tidb_users.py.tpl
Check List
Tests
Code changes
Side effects
None
Related changes
Does this PR introduce a user-facing change?: