Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatible with the old controller manager #856

Merged

Conversation

onlymellb
Copy link
Contributor

What problem does this PR solve?

Make the latest charts compatible with the old controller manager

What is changed and how does it work?

Check List

Tests

  • Manual test

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

make the latest  charts compatible with the old controller manager

@onlymellb
Copy link
Contributor Author

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onlymellb
Copy link
Contributor Author

/run-e2e-in-kind

@onlymellb onlymellb merged commit ac15208 into pingcap:master Sep 3, 2019
@onlymellb onlymellb deleted the compatible-old-controller-manager branch September 3, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants