Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-diff: add table match check #548

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Nov 15, 2021

What problem does this PR solve?

close #583

add table match check. when met

  1. source exist tables but target not.
  2. target exist tables but source not.
    after we use table-filter as parameter.

What is changed and how it works?

add a common check function in source.go

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lance6716
Copy link
Collaborator

need revert https://github.com/pingcap/ticdc/pull/3413 after this PR

@3pointer 3pointer marked this pull request as ready for review November 15, 2021 04:45
@3pointer
Copy link
Contributor Author

/hold

wait for 5.3.1

@3pointer
Copy link
Contributor Author

/unhold

@3pointer
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 641373e

@ti-chi-bot ti-chi-bot merged commit c5e06ff into pingcap:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync-diff will not report error when upstream has table but downstream doesn't
5 participants