Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "sync_diff_inspector: use statically build" #805

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Revert "sync_diff_inspector: use statically build" #805

merged 1 commit into from
Jun 12, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jun 12, 2024 •
edited
Loading

Reverts #785

Issue Number: ref #782.

the builds for darwin amd64 and arm64 targets are failed.

None

@wuhuizuo
Copy link
Contributor Author

/cc dveeden

@ti-chi-bot ti-chi-bot bot requested a review from dveeden June 12, 2024 05:30
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 12, 2024

@CharlesCheung96: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CharlesCheung96
Once this PR has been reviewed and has the lgtm label, please assign zwj-coder for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuhuizuo
Copy link
Contributor Author

/auto-cc

@wuhuizuo
Copy link
Contributor Author

/autocc

@wuhuizuo
Copy link
Contributor Author

fast revert it with bot rights

@ti-chi-bot ti-chi-bot bot merged commit 2c9fecb into master Jun 12, 2024
3 of 4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-785-disable-cgo-for-sync-diff branch June 12, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@dveeden dveeden Awaiting requested review from dveeden

Assignees
No one assigned
Labels
approved lgtm release-note size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wuhuizuo @CharlesCheung96 @ti-chi-bot