Skip to content

Commit

Permalink
planner: a new thread-safe lock-free plan cache (#54089)
Browse files Browse the repository at this point in the history
close #54057
  • Loading branch information
qw4990 authored Jun 25, 2024
1 parent c91bc20 commit 4869956
Show file tree
Hide file tree
Showing 4 changed files with 491 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/planner/core/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ go_library(
"physical_plans.go",
"plan.go",
"plan_cache.go",
"plan_cache_instance.go",
"plan_cache_lru.go",
"plan_cache_param.go",
"plan_cache_rebuild.go",
Expand Down Expand Up @@ -224,6 +225,7 @@ go_test(
"partition_pruning_test.go",
"physical_plan_test.go",
"physical_plan_trace_test.go",
"plan_cache_instance_test.go",
"plan_cache_lru_test.go",
"plan_cache_param_test.go",
"plan_cache_test.go",
Expand Down
229 changes: 229 additions & 0 deletions pkg/planner/core/plan_cache_instance.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,229 @@
// Copyright 2024 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package core

import (
"sort"
"sync"
"time"

"github.com/pingcap/tidb/pkg/sessionctx"
"go.uber.org/atomic"
)

// InstancePlanCache represents the instance/node level plan cache.
// Value and Opts should always be *PlanCacheValue and *PlanCacheMatchOpts, use any to avoid cycle-import.
type InstancePlanCache interface {
// Get gets the cached value from the cache according to key and opts.
Get(sctx sessionctx.Context, key string, opts any) (value any, ok bool)
// Put puts the key and value into the cache.
Put(sctx sessionctx.Context, key string, value, opts any) (succ bool)
// Evict evicts some cached values.
Evict(sctx sessionctx.Context) (evicted bool)
// MemUsage returns the total memory usage of this plan cache.
MemUsage() int64
}

// NewInstancePlanCache creates a new instance level plan cache.
func NewInstancePlanCache(softMemLimit, hardMemLimit int64) InstancePlanCache {
planCache := new(instancePlanCache)
planCache.softMemLimit.Store(softMemLimit)
planCache.hardMemLimit.Store(hardMemLimit)
return planCache
}

type instancePCNode struct {
value *PlanCacheValue
lastUsed atomic.Time
next atomic.Pointer[instancePCNode]
}

// instancePlanCache is a lock-free implementation of InstancePlanCache interface.
// [key1] --> [headNode1] --> [node1] --> [node2] --> [node3]
// [key2] --> [headNode2] --> [node4] --> [node5]
// [key3] --> [headNode3] --> [node6] --> [node7] --> [node8]
// headNode.value is always empty, headNode is designed to make it easier to implement.
type instancePlanCache struct {
heads sync.Map
totCost atomic.Int64

evictMutex sync.Mutex
softMemLimit atomic.Int64
hardMemLimit atomic.Int64
}

func (pc *instancePlanCache) getHead(key string, create bool) *instancePCNode {
headNode, ok := pc.heads.Load(key)
if ok { // cache hit
return headNode.(*instancePCNode)
}
if !create { // cache miss
return nil
}
newHeadNode := pc.createNode(nil)
actual, _ := pc.heads.LoadOrStore(key, newHeadNode)
if headNode, ok := actual.(*instancePCNode); ok { // for safety
return headNode
}
return nil
}

// Get gets the cached value according to key and opts.
func (pc *instancePlanCache) Get(sctx sessionctx.Context, key string, opts any) (value any, ok bool) {
headNode := pc.getHead(key, false)
if headNode == nil { // cache miss
return nil, false
}
return pc.getPlanFromList(sctx, headNode, opts)
}

func (*instancePlanCache) getPlanFromList(sctx sessionctx.Context, headNode *instancePCNode, opts any) (any, bool) {
for node := headNode.next.Load(); node != nil; node = node.next.Load() {
var matchOpts *PlanCacheMatchOpts
if opts != nil {
matchOpts = opts.(*PlanCacheMatchOpts)
}
if matchCachedPlan(sctx, node.value, matchOpts) { // v.Plan is read-only, no need to lock
node.lastUsed.Store(time.Now()) // atomically update the lastUsed field
return node.value, true
}
}
return nil, false
}

// Put puts the key and values into the cache.
// Due to some thread-safety issues, this Put operation might fail, use the returned succ to indicate it.
func (pc *instancePlanCache) Put(sctx sessionctx.Context, key string, value, opts any) (succ bool) {
vMem := value.(*PlanCacheValue).MemoryUsage()
if vMem+pc.totCost.Load() > pc.hardMemLimit.Load() {
return // do nothing if it exceeds the hard limit
}
headNode := pc.getHead(key, true)
if headNode == nil {
return false // for safety
}
if _, ok := pc.getPlanFromList(sctx, headNode, opts); ok {
return // some other thread has inserted the same plan before
}

firstNode := headNode.next.Load()
currNode := pc.createNode(value)
currNode.next.Store(firstNode)
if headNode.next.CompareAndSwap(firstNode, currNode) { // if failed, some other thread has updated this node,
pc.totCost.Add(vMem) // then skip this Put and wait for the next time.
succ = true
}
return
}

// Evict evicts some values. There should be a background thread to perform the eviction.
// step 1: iterate all values to collect their last_used
// step 2: estimate an eviction threshold time based on all last_used values
// step 3: iterate all values again and evict qualified values
func (pc *instancePlanCache) Evict(_ sessionctx.Context) (evicted bool) {
pc.evictMutex.Lock() // make sure only one thread to trigger eviction for safety
defer pc.evictMutex.Unlock()
if pc.totCost.Load() < pc.softMemLimit.Load() {
return // do nothing
}
lastUsedTimes := make([]time.Time, 0, 64)
pc.foreach(func(_, this *instancePCNode) bool { // step 1
lastUsedTimes = append(lastUsedTimes, this.lastUsed.Load())
return false
})
threshold := pc.calcEvictionThreshold(lastUsedTimes) // step 2
pc.foreach(func(prev, this *instancePCNode) bool { // step 3
if !this.lastUsed.Load().After(threshold) { // if lastUsed<=threshold, evict this value
if prev.next.CompareAndSwap(this, this.next.Load()) { // have to use CAS since
pc.totCost.Sub(this.value.MemoryUsage()) // it might have been updated by other thread
evicted = true
return true
}
}
return false
})

// post operation: clear empty heads in pc.Heads
keys, headNodes := pc.headNodes()
for i, headNode := range headNodes {
if headNode.next.Load() == nil {
pc.heads.Delete(keys[i])
}
}
return
}

// MemUsage returns the memory usage of this plan cache.
func (pc *instancePlanCache) MemUsage() int64 {
return pc.totCost.Load()
}

func (pc *instancePlanCache) calcEvictionThreshold(lastUsedTimes []time.Time) (t time.Time) {
if len(lastUsedTimes) == 0 {
return
}
totCost, softMemLimit := pc.totCost.Load(), pc.softMemLimit.Load()
avgPerPlan := totCost / int64(len(lastUsedTimes))
if avgPerPlan <= 0 {
return
}
memToRelease := totCost - softMemLimit
// (... +avgPerPlan-1) is used to try to keep the final memory usage below the soft mem limit.
numToEvict := (memToRelease + avgPerPlan - 1) / avgPerPlan
if numToEvict <= 0 {
return
}
sort.Slice(lastUsedTimes, func(i, j int) bool {
return lastUsedTimes[i].Before(lastUsedTimes[j])
})
if len(lastUsedTimes) < int(numToEvict) {
return // for safety, avoid index-of-range panic
}
return lastUsedTimes[numToEvict-1]
}

func (pc *instancePlanCache) foreach(callback func(prev, this *instancePCNode) (thisRemoved bool)) {
_, headNodes := pc.headNodes()
for _, headNode := range headNodes {
for prev, this := headNode, headNode.next.Load(); this != nil; {
thisRemoved := callback(prev, this)
if !thisRemoved { // this node is removed, no need to update the prev node in this case
prev, this = this, this.next.Load()
} else {
this = this.next.Load()
}
}
}
}

func (pc *instancePlanCache) headNodes() ([]string, []*instancePCNode) {
keys := make([]string, 0, 64)
headNodes := make([]*instancePCNode, 0, 64)
pc.heads.Range(func(k, v any) bool {
keys = append(keys, k.(string))
headNodes = append(headNodes, v.(*instancePCNode))
return true
})
return keys, headNodes
}

func (*instancePlanCache) createNode(value any) *instancePCNode {
node := new(instancePCNode)
if value != nil {
node.value = value.(*PlanCacheValue)
}
node.lastUsed.Store(time.Now())
return node
}
Loading

0 comments on commit 4869956

Please sign in to comment.