-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ddl: fix panic tidb-server doesn't release table lock (#19586)
- Loading branch information
1 parent
b7364a3
commit 8ae5b1c
Showing
3 changed files
with
174 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| // Copyright 2020 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package util | ||
|
|
||
| import ( | ||
| "context" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/pingcap/errors" | ||
| "github.com/pingcap/parser/model" | ||
| "github.com/pingcap/tidb/util/logutil" | ||
| "go.etcd.io/etcd/clientv3" | ||
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| const ( | ||
| defaultRetryCnt = 5 | ||
| defaultRetryInterval = time.Millisecond * 200 | ||
| defaultTimeout = time.Second | ||
| ) | ||
|
|
||
| // DeadTableLockChecker uses to check dead table locks. | ||
| // If tidb-server panic or killed by others, the table locks hold by the killed tidb-server maybe doesn't released. | ||
| type DeadTableLockChecker struct { | ||
| etcdCli *clientv3.Client | ||
| } | ||
|
|
||
| // NewDeadTableLockChecker creates new DeadLockChecker. | ||
| func NewDeadTableLockChecker(etcdCli *clientv3.Client) DeadTableLockChecker { | ||
| return DeadTableLockChecker{ | ||
| etcdCli: etcdCli, | ||
| } | ||
| } | ||
|
|
||
| func (d *DeadTableLockChecker) getAliveServers(ctx context.Context) (map[string]struct{}, error) { | ||
| var err error | ||
| var resp *clientv3.GetResponse | ||
| allInfos := make(map[string]struct{}) | ||
| for i := 0; i < defaultRetryCnt; i++ { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return nil, ctx.Err() | ||
| default: | ||
| } | ||
| childCtx, cancel := context.WithTimeout(ctx, defaultTimeout) | ||
| resp, err = d.etcdCli.Get(childCtx, DDLAllSchemaVersions, clientv3.WithPrefix()) | ||
| cancel() | ||
| if err != nil { | ||
| logutil.BgLogger().Info("[ddl] clean dead table lock get alive servers failed.", zap.Error(err)) | ||
| time.Sleep(defaultRetryInterval) | ||
| continue | ||
| } | ||
| for _, kv := range resp.Kvs { | ||
| serverID := strings.TrimPrefix(string(kv.Key), DDLAllSchemaVersions+"/") | ||
| allInfos[serverID] = struct{}{} | ||
| } | ||
| return allInfos, nil | ||
| } | ||
| return nil, errors.Trace(err) | ||
| } | ||
|
|
||
| // GetDeadLockedTables gets dead locked tables. | ||
| func (d *DeadTableLockChecker) GetDeadLockedTables(ctx context.Context, schemas []*model.DBInfo) (map[model.SessionInfo][]model.TableLockTpInfo, error) { | ||
| if d.etcdCli == nil { | ||
| return nil, nil | ||
| } | ||
| aliveServers, err := d.getAliveServers(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| deadLockTables := make(map[model.SessionInfo][]model.TableLockTpInfo) | ||
| for _, schema := range schemas { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return nil, ctx.Err() | ||
| default: | ||
| } | ||
| for _, tbl := range schema.Tables { | ||
| if tbl.Lock == nil { | ||
| continue | ||
| } | ||
| for _, se := range tbl.Lock.Sessions { | ||
| if _, ok := aliveServers[se.ServerID]; !ok { | ||
| deadLockTables[se] = append(deadLockTables[se], model.TableLockTpInfo{ | ||
| SchemaID: schema.ID, | ||
| TableID: tbl.ID, | ||
| Tp: tbl.Lock.Tp, | ||
| }) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return deadLockTables, nil | ||
| } |