window function: function name of error message should be lowercase

pingcap · Jul 8, 2019 · b43af42 · b43af42
1 parent 94d8127
commit b43af42
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/planner/core/logical_plan_builder.go b/planner/core/logical_plan_builder.go
@@ -3148,7 +3148,7 @@ func (b *PlanBuilder) buildWindowFunctions(p LogicalPlan, groupedFuncs map[*ast.
 				return nil, nil, err
 			}
 			if desc == nil {
-				return nil, nil, ErrWrongArguments.GenWithStackByArgs(windowFunc.F)
+				return nil, nil, ErrWrongArguments.GenWithStackByArgs(strings.ToLower(windowFunc.F))
 			}
 			preArgs += len(windowFunc.Args)
 			desc.WrapCastForAggArgs(b.ctx)

diff --git a/planner/core/logical_plan_test.go b/planner/core/logical_plan_test.go
@@ -2263,6 +2263,10 @@ func (s *testPlanSuite) TestWindowFunction(c *C) {
 			sql:    "select nth_value(a, 1.0) over() from t",
 			result: "[planner:1210]Incorrect arguments to nth_value",
 		},
+		{
+			sql:    "SELECT NTH_VALUE(a, 1.0) OVER() FROM t",
+			result: "[planner:1210]Incorrect arguments to nth_value",
+		},
 		{
 			sql:    "select nth_value(a, 0) over() from t",
 			result: "[planner:1210]Incorrect arguments to nth_value",