Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining MySQL 5.7 functions #158

Closed
7 of 11 tasks
ngaut opened this issue Sep 15, 2015 · 5 comments
Closed
7 of 11 tasks

Add remaining MySQL 5.7 functions #158

ngaut opened this issue Sep 15, 2015 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@ngaut
Copy link
Member

ngaut commented Sep 15, 2015 •
edited by morgo
Loading

Via the MySQL Manual:
@shijie-wu
Copy link

Hi, I would like to contribute to tidb and after watching the presentation of Qi Liu, I guess this might be a good starting point. It would be nice if some further pointers could be provided. Thanks in advanced :)

@ngaut
Copy link
Member Author

ngaut commented Sep 26, 2015

Thank you @w5s5j
I think #236 is a good start :)
Fire an issue when you are ready to hunt any of the functions in #236

@qiuyesuifeng qiuyesuifeng added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed easy labels Sep 28, 2015
@Tratar
Copy link
Contributor

Tratar commented Dec 30, 2016

Hi, I am willing to contribute to tidb a bit. Is there any function I could try implementing? Thanks a lot.

@c4pt0r
Copy link
Member

c4pt0r commented Dec 31, 2016 •
edited
Loading

@Tratar
we have a document for contributors who wants to add built-in functions to TiDB, you can pick a built-in function in #236, and follow the steps in https://pingcap.github.io/blog/2016/12/19/adding-built-in-function/
Happy hacking :)

@shenli
Copy link
Member

shenli commented Dec 31, 2016

@Tratar You can refer to #310 and #236 for the unimplemented builtin functions. If you have any problem, please let us know.
Thanks!

@morgo morgo changed the title Add more functions Add remaining MySQL 5.7 functions Nov 24, 2018
This was referenced Nov 24, 2018
Closed
Closed
@ngaut ngaut closed this as completed Apr 18, 2019
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
@amyangfei @lonng
tests: add kill lightning test in checkpoint_chunks case (pingcap#158)
82ed51b 
use gofail to control lightning to kill itself after one chunk is imported
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
@kennytm
tests: fix a test failure due to conflict between pingcap#145 and pin…
43fdfc3 
…gcap#158 (pingcap#159)

* tests: fix a test failure due to conflict between pingcap#145 and pingcap#158

* restore: apply the row count limit to failpoint KillIfImportedChunk too
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
@kennytm @3pointer
Reduce TiDB dependencies (pingcap#158)
4492b8f 
* utils: exclude mock_cluster outside of unit test

* utils: remove unused ResultSetToStringSlice()

* *: abstract away dependencies of tidb/session into a Glue interface

* *: fix hound lint

* util,mock: move utils.MockCluster to mock.Cluster

* restore: fix test build failure

Co-authored-by: 3pointer <[email protected]>
okJiang pushed a commit to okJiang/tidb that referenced this issue Oct 19, 2021
@lichunzhu
make dumpling support dumping view (pingcap#158)
5129591 
* support dump view

* add unit tests

* add more comments

* fix integration tests

* address comment

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@c4pt0r @ngaut @shenli @Tratar @qiuyesuifeng @shijie-wu