Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParseTimeFromNum function for timezone support. #21

Closed
qiuyesuifeng opened this issue Sep 6, 2015 · 0 comments
Closed

Add ParseTimeFromNum function for timezone support. #21

qiuyesuifeng opened this issue Sep 6, 2015 · 0 comments

Comments

@qiuyesuifeng
Copy link
Member

see #19 and #20
ParseTimeFromNum function not consider timezone, when convert to timestamp type, time validity check does not work well.

we should check following tests later.

    table := []struct {
        Input                int64
        ExpectDateTimeError  bool
        ExpectDateTimeValue  string
        ExpectTimeStampError bool
        ExpectTimeStampValue string
        ExpectDateError      bool
        ExpectDateValue      string
    }{
        {700101000000, false, "1970-01-01 00:00:00", false, "1970-01-01 00:00:00", false, "1970-01-01"},
        {380119031407, false, "2038-01-19 03:14:07", false, "2038-01-19 03:14:07", false, "2038-01-19"},
       }
@ngaut ngaut closed this as completed Sep 9, 2015
wjhuang2016 referenced this issue in wjhuang2016/tidb Oct 9, 2020
infoschema: add PARTITION_DESCRIPTION in PARTITIONS table for list pa…
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
* use efficient http pd api to get region count

* fix test

* add unit test

* address comment
xhebox pushed a commit to xhebox/tidb that referenced this issue Sep 28, 2021
crazycs520 added a commit to crazycs520/tidb that referenced this issue Jan 7, 2022
ywqzzy pushed a commit to ywqzzy/tidb that referenced this issue Jul 17, 2023
add back buffer pool and fix small amount of data scenario
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Jul 29, 2024
br: implement wrap migrations into log iterator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants