Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let top-level projection can push down to TiFlash when mpp is not enforced. #26242

Closed
LittleFall opened this issue Jul 14, 2021 · 0 comments · Fixed by #27029
Closed

Let top-level projection can push down to TiFlash when mpp is not enforced. #26242

LittleFall opened this issue Jul 14, 2021 · 0 comments · Fixed by #27029
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@LittleFall
Copy link
Contributor

Enhancement

#25450 support top-level projection push down to TiFlash, but it only takes effect when mpp mode is enforced. This changes the semantics of tidb_enforce_mpp: It will introduce new optimization rules instead of just ignoring the optimizer cost estimate.、

It is actually maintaining two sets of optimizers.

#26207 wants to fix it, but it finally closed because the influence on optimizer cost model can't be evaluated.

We need a better way to merge this optimize rule into the current optimizer.

@LittleFall LittleFall added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Jul 14, 2021
ti-chi-bot pushed a commit that referenced this issue Apr 22, 2022
espresso98 added a commit to espresso98/tidb that referenced this issue Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant