migrate test-infra to testify for executor_test.go

[tisonkun]

All tests listed below is moved to executor_legacy_test.go file.

• migrate test-infra to testify for executor_test.go testSuite #33425
• migrate test-infra to testify for executor_test.go testSuiteP1 #33426
• migrate test-infra to testify for executor_test.go testSuiteP2 #33427
• migrate test-infra to testify for executor_test.go testSuite1 #33428
• migrate test-infra to testify for executor_test.go testSerialSuite2 #33429
• migrate test-infra to testify for executor_test.go testSuiteWithCliBaseCharset #33430
• migrate test-infra to testify for executor_test.go testSuite2 #33431
• migrate test-infra to testify for executor_test.go testSuite3 #33432
• migrate test-infra to testify for executor_test.go testSuite6 #33433
• migrate test-infra to testify for executor_test.go testSuite8 #33434
• migrate test-infra to testify for executor_test.go testRecoverTable #33435
• migrate test-infra to testify for executor_test.go testClusterTableSuite #33436
• migrate test-infra to testify for executor_test.go testSplitTable #33437
• migrate test-infra to testify for executor_test.go testSerialSuite1 #33438
• migrate test-infra to testify for executor_test.go testSlowQuery #33439
• migrate test-infra to testify for executor_test.go globalIndexSuite #33440
• migrate test-infra to testify for executor_test.go testSerialSuite #33441
• migrate test-infra to testify for executor_test.go testCoprCache #33442
• migrate test-infra to testify for executor_test.go testResourceTagSuite #33443

[karuppiah7890]

/assign

[karuppiah7890]

I see lot of test suite setup and tear down as part of this test. Just from an overview, it looks like we can also do the setup at test level. But if we still want to do the setup at test suite level - we can choose to use TestMain but that would be doing setup for all tests in the package and not just executor_test.go test, or we can try to use testify's test suite feature. Let me know what you folks think

cc @tisonkun

[tisonkun]

Hi @karuppiah7890 ! There is a similar case #28300 you can refer to. I think it can directly answer your question. Let me know if still something unclear.

[karuppiah7890]

@tisonkun So, if I'm understanding right, we do setup once in a test and then use t.Run and run sub tests?

[tisonkun]

@karuppiah7890 yep. Actually it is somehow we do suite batch logic manually, but this template code is similar with

var _ = Suite(XxxSuite{})

so I'm ok with it.

[karuppiah7890]

Cool ! I'll do that ! 👍

[tisonkun]

@XuHuaiyu @hawkingrei I think we may need an expert to split tests in executor_test.go first and migrate them with a file splitting.

[hawkingrei]

@tisonkun @XuHuaiyu Yes, I think so. I start to split tests.

[tisonkun]

@hawkingrei I suggest you try to migrate tests rely on testdata first, so that we can remove the legacy testdata code.

[tisonkun]

@hawkingrei @karuppiah7890 I've split this issue into workable subtasks, and the skeleton is constructed in #33394 and you can refer to an example in #33402.

Welcome to take over some of the subtasks.

[tisonkun]

Accidentally closed. Reopen.