Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for ddl/db_test.go #28636

Closed
13 tasks done
Tracked by #27180
tisonkun opened this issue Oct 8, 2021 · 8 comments
Closed
13 tasks done
Tracked by #27180

migrate test-infra to testify for ddl/db_test.go #28636

tisonkun opened this issue Oct 8, 2021 · 8 comments
Assignees
@tisonkun
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Oct 8, 2021 •
edited
Loading

@tisonkun tisonkun mentioned this issue Oct 8, 2021
Closed
34 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 8, 2021
@3mard
Copy link
Contributor

3mard commented Oct 8, 2021

/assign

@hawkingrei
Copy link
Member

/assign

@hawkingrei hawkingrei mentioned this issue Jan 28, 2022
Closed
12 tasks
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Jan 29, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 6, 2022

I'm splitting tests in this file.

@hawkingrei
Copy link
Member

I'm splitting tests in this file.

Good Job!

@tisonkun tisonkun assigned tisonkun and unassigned hawkingrei and 3mard Mar 6, 2022
@hawkingrei hawkingrei mentioned this issue Mar 9, 2022
Merged
12 tasks
@tisonkun tisonkun mentioned this issue Mar 9, 2022
Closed
12 tasks
@wjhuang2016
Copy link
Member

wjhuang2016 commented Mar 9, 2022 •
edited
Loading

I plan to rewrite some tests related to cancelDDLJob.
Specifically,

  • TestCancelAddIndexPanic
  • TestCancelDropIndex
  • TestCancelDropPrimaryKey
  • TestCancelTruncateTable
  • TestCancelRenameIndex
  • TestCancelDropTableAndSchema
  • TestCancelAddTableAndDropTablePartition
  • TestCancelJobWriteConflict
  • TestPartitionCancelAddIndex
  • TestPartitionCancelAddPrimaryKey
  • TestCancelAddIndex1
  • TestModifyColumnRollBack

I would remove these tests in the DDL package and add the new test in the util/admin package.

@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 9, 2022

@wjhuang2016 thanks for your information! I'll avoid to touch them in the next few days.

@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 9, 2022

@wjhuang2016 you may create an issue to do the rewriter at once or in multiple subtasks. I'm afraid that the todo list here would be forgotten later 🤣

ti-chi-bot pushed a commit that referenced this issue Mar 9, 2022
@hawkingrei
ddl: migrate test-infra to testify for rename tests (#32971)
8ab1f65 
ref #28636
@tisonkun
Copy link
Contributor Author

Finally we finish it! Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tisonkun tisonkun

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: migrate test-infra to testify for db_test hawkingrei/tidb
4 participants
@hawkingrei @wjhuang2016 @tisonkun @3mard