Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic pruning mode also for transactions #29851

Closed
mjonss opened this issue Nov 16, 2021 · 0 comments · Fixed by #31634
Closed

Allow dynamic pruning mode also for transactions #29851

mjonss opened this issue Nov 16, 2021 · 0 comments · Fixed by #31634
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@mjonss
Copy link
Contributor

mjonss commented Nov 16, 2021

Enhancement

Revert #26876 (#26719) and fix the underlying issue.

Might also be related to #28073?

See:

// UseDynamicPartitionPrune indicates whether use new dynamic partition prune.
func (s *SessionVars) UseDynamicPartitionPrune() bool {
if s.InTxn() {
// UnionScan cannot get partition table IDs in dynamic-mode, this is a quick-fix for issues/26719,
// please see it for more details.
return false
}
return PartitionPruneMode(s.PartitionPruneMode.Load()) == Dynamic
}

where it explicitly turns off dynamic pruning mode if there is an ongoing transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
1 participant