Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #30288 results in 5.4%-10% performance regression in read-heavy workloads #31014

Closed
Yui-Song opened this issue Dec 24, 2021 · 4 comments · Fixed by #31061
Closed

PR #30288 results in 5.4%-10% performance regression in read-heavy workloads #31014

Yui-Song opened this issue Dec 24, 2021 · 4 comments · Fixed by #31061
Assignees
Labels
feature/developing the related feature is in development found/automation Found by automation tests severity/critical sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@Yui-Song
Copy link
Contributor

Yui-Song commented Dec 24, 2021

Bug Report

PR #30288 results in 5.4%-10% performance regression in read-heavy workloads

1. Minimal reproduce step (Required)

  1. Deploy a cluster with nightly version
  2. Turn on Prepare plan cache
  3. Run sysbench oltp_read_only or other read-heavy workloads

2. What did you expect to see? (Required)

3. What did you see instead (Required)

The performance of workloads drops 5.4%-10% compared with their baseline.
You can take commit 7555536 as baseline.

4. What is your TiDB version? (Required)

commit 4dc385c

@Yui-Song Yui-Song added type/bug The issue is confirmed as a bug. severity/critical labels Dec 24, 2021
@Yui-Song Yui-Song assigned Yui-Song and tangenta and unassigned Yui-Song Dec 24, 2021
@bb7133
Copy link
Member

bb7133 commented Dec 24, 2021

Interesting... we have found another performance regression(#30936) and thought it was resolved by #30937.

@ChenPeng2013 ChenPeng2013 added the sig/sql-infra SIG: SQL Infra label Dec 27, 2021
@Yui-Song
Copy link
Contributor Author

The performance of sysbench read-heavy workloads like: oltp_read_write, oltp_read_only, select_random_points have been improved by #30937. However, the performance of shenma, a read-heavy bank workload, still drop 8.9%-10%. It's a CPU-consuming workload.

@Yui-Song
Copy link
Contributor Author

Please refer to the internal OLTP Benchmark Overview page for more details.

@Yui-Song Yui-Song added the found/automation Found by automation tests label Dec 27, 2021
@bb7133 bb7133 added the feature/developing the related feature is in development label Dec 28, 2021
@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/developing the related feature is in development found/automation Found by automation tests severity/critical sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants