Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of system variables is messy. #33086

Closed
CbcWestwolf opened this issue Mar 15, 2022 · 2 comments · Fixed by #33149
Closed

The order of system variables is messy. #33086

CbcWestwolf opened this issue Mar 15, 2022 · 2 comments · Fixed by #33149
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@CbcWestwolf
Copy link
Member

Enhancement

The system variables are declared in sysvar.go. With the increase in the number of sysvars, their order tends to be messy.

With the introduction of the INSTANCE scope, I think it may be better to re-organize the sysvars by their scopes.

@CbcWestwolf CbcWestwolf added the type/enhancement The issue or PR belongs to an enhancement. label Mar 15, 2022
@CbcWestwolf
Copy link
Member Author

/assign

@morgo
Copy link
Contributor

morgo commented Mar 15, 2022

I agree it would be useful to be more organized :-) Either by scope or function area (since some variables of the same function will have different scopes).

For user documentation we have them in alphabetical order, but constantly introduce cases where we break the order :( I have a script that I run every few weeks to fix it. You can see the typical bugs introduced in pingcap/docs#7737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants