Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap version is not correctly incremented #33163

Closed
morgo opened this issue Mar 16, 2022 · 0 comments · Fixed by #33184
Closed

bootstrap version is not correctly incremented #33163

morgo opened this issue Mar 16, 2022 · 0 comments · Fixed by #33184
Assignees
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@morgo
Copy link
Contributor

morgo commented Mar 16, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

From code inspection of bootstrap.go, I can see a bug introduced in #33094

Version 85 is introduced, but the currentBootstrapVersion is still on version 84:

tidb/session/bootstrap.go

Lines 588 to 590 in c4fbc8e

// currentBootstrapVersion is defined as a variable, so we can modify its value for testing.
// please make sure this is the largest version
var currentBootstrapVersion int64 = version84

Without this, the code won't run.

2. What did you expect to see? (Required)

version 85.

4. What is your TiDB version? (Required)

master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants