-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incremental restore doesn't empty query job. #33322
Comments
/assign WangLe1321 |
@joccau: GitHub didn't allow me to assign the following users: WangLe1321. Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign WangLe1321 |
There is another problem is sql mode of ddl job. For ddl jobs which don't belong to reorg ddl, there is no sql mode information recorded, and we can only set sql mode '' when execute these ddl jobs during restoring, which may result in errors or hidden bugs. |
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
It's hard to reproduce it but easy to fix.
because we use
ExecuteInternal
to Execute DDL job queries during incremental restore.and sometimes this query might be nil. so the check will not pass.
To Fix it we can ignore the empty job.Query in
tidb/br/pkg/restore/client.go
Line 750 in 49f291d
2. What did you expect to see? (Required)
incremental restore succeed.
3. What did you see instead (Required)
4. What is your TiDB version? (Required)
master
The text was updated successfully, but these errors were encountered: