Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

innodb_lock_wait_timeout MaxValue > max-txn-ttl #33472

Closed
morgo opened this issue Mar 25, 2022 · 0 comments · Fixed by #33473
Closed

innodb_lock_wait_timeout MaxValue > max-txn-ttl #33472

morgo opened this issue Mar 25, 2022 · 0 comments · Fixed by #33473
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.

Comments

@morgo
Copy link
Contributor

morgo commented Mar 25, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Discovered in #33361

The max for the amount of time locks can be held is 1hr (3600000 ms). But the max that pessimistic lock wait timeout can be is 34 years. These aren't quite the same thing, but it makes sense to unify the two such that you can only wait up to 1hr for a pessimistic lock.

Otherwise there are weird scenarios where you are waiting on a lock for >1hr, but your existing locks expire while waiting.

2. What did you expect to see? (Required)

Same values (or similar range)

So I propose we set innodb_lock_wait_timeout max value to 3600.

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

@morgo morgo added the type/bug The issue is confirmed as a bug. label Mar 25, 2022
@morgo morgo added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants