Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FAIL] executor TestPointGetLockExistKey #33750

Closed
Tracked by #33745
tiancaiamao opened this issue Apr 7, 2022 · 2 comments · Fixed by #33862
Closed
Tracked by #33745

[FAIL] executor TestPointGetLockExistKey #33750

tiancaiamao opened this issue Apr 7, 2022 · 2 comments · Fixed by #33862
Assignees
@tiancaiamao
Labels
component/test sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@tiancaiamao
Copy link
Contributor

No description provided.

@tiancaiamao tiancaiamao mentioned this issue Apr 7, 2022
Open
25 tasks
@tiancaiamao
Copy link
Contributor Author 

==================
WARNING: DATA RACE
Read at 0x00c000782048 by goroutine 90:
  github.com/pingcap/tidb/executor_test.TestPointGetLockExistKey.func2()
      /home/genius/project/src/github.com/pingcap/tidb/executor/point_get_test.go:797 +0x4f
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      /home/genius/project/src/github.com/pingcap/tidb/util/wait_group_wrapper.go:33 +0x73

Previous write at 0x00c000782048 by goroutine 89:
  github.com/pingcap/tidb/executor_test.TestPointGetLockExistKey()
      /home/genius/project/src/github.com/pingcap/tidb/executor/point_get_test.go:786 +0x1e8
  testing.tRunner()
      /home/genius/project/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /home/genius/project/go/src/testing/testing.go:1486 +0x47

Goroutine 90 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      /home/genius/project/src/github.com/pingcap/tidb/util/wait_group_wrapper.go:31 +0xdc
  github.com/pingcap/tidb/executor_test.TestPointGetLockExistKey()
      /home/genius/project/src/github.com/pingcap/tidb/executor/point_get_test.go:796 +0x371
  testing.tRunner()
      /home/genius/project/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /home/genius/project/go/src/testing/testing.go:1486 +0x47

Goroutine 89 (running) created at:
  testing.(*T).Run()
      /home/genius/project/go/src/testing/testing.go:1486 +0x724
  testing.runTests.func1()
      /home/genius/project/go/src/testing/testing.go:1839 +0x99
  testing.tRunner()
      /home/genius/project/go/src/testing/testing.go:1439 +0x213
  testing.runTests()
      /home/genius/project/go/src/testing/testing.go:1837 +0x7e4
  testing.(*M).Run()
      /home/genius/project/go/src/testing/testing.go:1719 +0xa71
  github.com/pingcap/tidb/testkit/testmain.(*testingM).Run()
      /home/genius/project/src/github.com/pingcap/tidb/testkit/testmain/wrapper.go:28 +0x42
  go.uber.org/goleak.VerifyTestMain()
      /home/genius/go/pkg/mod/go.uber.org/[email protected]/testmain.go:53 +0x59
  github.com/pingcap/tidb/executor_test.TestMain()
      /home/genius/project/src/github.com/pingcap/tidb/executor/main_test.go:70 +0xab6
  main.main()
      _testmain.go:2123 +0x317
==================

TiDB version 37d86da

@tiancaiamao
Copy link
Contributor Author 

==================
WARNING: DATA RACE
Read at 0x00c000782050 by goroutine 90:
  github.com/pingcap/tidb/executor_test.TestPointGetLockExistKey.func2()
      /home/genius/project/src/github.com/pingcap/tidb/executor/point_get_test.go:797 +0x64
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      /home/genius/project/src/github.com/pingcap/tidb/util/wait_group_wrapper.go:33 +0x73

Previous write at 0x00c000782050 by goroutine 89:
  github.com/pingcap/tidb/executor_test.TestPointGetLockExistKey()
      /home/genius/project/src/github.com/pingcap/tidb/executor/point_get_test.go:786 +0x1e8
  testing.tRunner()
      /home/genius/project/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /home/genius/project/go/src/testing/testing.go:1486 +0x47

Goroutine 90 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      /home/genius/project/src/github.com/pingcap/tidb/util/wait_group_wrapper.go:31 +0xdc
  github.com/pingcap/tidb/executor_test.TestPointGetLockExistKey()
      /home/genius/project/src/github.com/pingcap/tidb/executor/point_get_test.go:796 +0x371
  testing.tRunner()
      /home/genius/project/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /home/genius/project/go/src/testing/testing.go:1486 +0x47

Goroutine 89 (running) created at:
  testing.(*T).Run()
      /home/genius/project/go/src/testing/testing.go:1486 +0x724
  testing.runTests.func1()
      /home/genius/project/go/src/testing/testing.go:1839 +0x99
  testing.tRunner()
      /home/genius/project/go/src/testing/testing.go:1439 +0x213
  testing.runTests()
      /home/genius/project/go/src/testing/testing.go:1837 +0x7e4
  testing.(*M).Run()
      /home/genius/project/go/src/testing/testing.go:1719 +0xa71
  github.com/pingcap/tidb/testkit/testmain.(*testingM).Run()
      /home/genius/project/src/github.com/pingcap/tidb/testkit/testmain/wrapper.go:28 +0x42
  go.uber.org/goleak.VerifyTestMain()
      /home/genius/go/pkg/mod/go.uber.org/[email protected]/testmain.go:53 +0x59
  github.com/pingcap/tidb/executor_test.TestMain()
      /home/genius/project/src/github.com/pingcap/tidb/executor/main_test.go:70 +0xab6
  main.main()
      _testmain.go:2123 +0x317
==================

@tiancaiamao tiancaiamao self-assigned this Apr 11, 2022
@tiancaiamao tiancaiamao mentioned this issue Apr 11, 2022
Merged
12 tasks
@tiancaiamao tiancaiamao added type/enhancement The issue or PR belongs to an enhancement. component/test sig/sql-infra SIG: SQL Infra labels Apr 11, 2022
ti-chi-bot pushed a commit that referenced this issue Apr 11, 2022
@tiancaiamao
exeuctor: fix data race for TestPointGetLockExistKey (#33862)
d63587f 
close #33750
@tiancaiamao tiancaiamao mentioned this issue Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiancaiamao tiancaiamao

Labels
component/test sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exeuctor: fix data race for TestPointGetLockExistKey tiancaiamao/tidb
1 participant
@tiancaiamao