Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: set ctx for ComChangeUser maybe trigger panic at ShowProcessList #33892

Closed
knull-cn opened this issue Apr 12, 2022 · 1 comment · Fixed by #33894
Closed

server: set ctx for ComChangeUser maybe trigger panic at ShowProcessList #33892

knull-cn opened this issue Apr 12, 2022 · 1 comment · Fixed by #33894
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. fixes-5.4.1 severity/major type/bug The issue is confirmed as a bug.

Comments

@knull-cn
Copy link
Contributor

knull-cn commented Apr 12, 2022 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. execute 'ComChangeUser' many times

2. What did you expect to see? (Required)

run success and response ok

3. What did you see instead (Required)

maybe trigger panic
origin_img_v2_1caeb186-0ebb-439b-82a6-9b7c8555b77g

4. What is your TiDB version? (Required)

master
@knull-cn knull-cn added the type/bug The issue is confirmed as a bug. label Apr 12, 2022
@knull-cn
Copy link
Contributor Author

after #33703, set clientConn::ctx = nil at clientConn::handleChangeUser
in package expensivequery, Handle::Run will call server::ShowProcessList every 100 Millisecond, maybe triggering trigger panic

it will be also maybe panic when call server::ShowProcessList in other case

@knull-cn knull-cn mentioned this issue Apr 12, 2022
Merged
4 tasks
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 labels Apr 13, 2022
@bb7133 bb7133 removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 labels Apr 13, 2022
ti-chi-bot pushed a commit that referenced this issue Apr 14, 2022
@knull-cn
server: openSession instead set nil when changeUser (#33894)
1046137 
close #33892
@ti-srebot ti-srebot mentioned this issue May 6, 2022
Merged
4 tasks
@tiancaiamao tiancaiamao mentioned this issue May 6, 2022
Merged
4 tasks
@VelocityLight VelocityLight added the affects-5.4 This bug affects 5.4.x versions. label May 6, 2022
ti-chi-bot pushed a commit that referenced this issue May 7, 2022
@ti-srebot
server: openSession instead set nil when changeUser (#33894) (#34427)
be48447 
close #33892
@tiancaiamao tiancaiamao mentioned this issue May 7, 2022
Closed
@ti-srebot ti-srebot mentioned this issue Jun 15, 2022
Merged
4 tasks
@XuHuaiyu XuHuaiyu added the affects-5.3 This bug affects 5.3.x versions. label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. fixes-5.4.1 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: openSession instead set nil when changeUser knull-cn/tidb
7 participants
@bb7133 @tiancaiamao @knull-cn @VelocityLight @XuHuaiyu @wjhuang2016 @ti-chi-bot