Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopSQL & statement summary use a lot of memory #34525

Closed
zyguan opened this issue May 10, 2022 · 8 comments
Closed

TopSQL & statement summary use a lot of memory #34525

zyguan opened this issue May 10, 2022 · 8 comments
Labels
severity/major sig/diagnosis SIG: Diagnosis type/bug The issue is confirmed as a bug.

Comments

@zyguan
Copy link
Contributor

zyguan commented May 10, 2022

General Question

We test tidb with sqllogic daily and it fails recently. The case fails because the tidb gets OOM killed and it seems that the memory is maily used by topsql & statement summary.

2022-05-10_141922

heap-dump.tar.gz

@zyguan zyguan added type/question The issue belongs to a question. sig/diagnosis SIG: Diagnosis labels May 10, 2022
@zyguan
Copy link
Contributor Author

zyguan commented May 10, 2022

/cc @breezewish

@mornyx
Copy link
Contributor

mornyx commented May 10, 2022

Hi @zyguan, could you please provide the version & commit id of this TiDB instance? Also includes the num of CPU cores and memory size of the machine.

@zyguan
Copy link
Contributor Author

zyguan commented May 10, 2022

Hi @zyguan, could you please provide the version & commit id of this TiDB instance? Also includes the num of CPU cores and memory size of the machine.

The latest master is used and resource quotas described here.

@mornyx
Copy link
Contributor

mornyx commented May 10, 2022

The latest master is used and resource quotas described here.

Did you turn on the TopSQL during the test?

@zyguan
Copy link
Contributor Author

zyguan commented May 10, 2022

The latest master is used and resource quotas described here.

Did you turn on the TopSQL during the test?

No special settings for enabling TopSQL, it shall be disabled by default.

@mornyx
Copy link
Contributor

mornyx commented May 11, 2022

image

#34558 has been merged, so the green part should have been resolved. Whether the blue part will cause the leak is still unclear, so we need to continue to observe the next daily test report. cc @zyguan

@zyguan zyguan added type/bug The issue is confirmed as a bug. and removed type/question The issue belongs to a question. labels May 12, 2022
@mornyx
Copy link
Contributor

mornyx commented May 13, 2022

Whether the blue part will cause the leak is still unclear, so we need to continue to observe the next daily test report.

Does the memory leak still exist in the latest test? I see that the sqllogic tests on TCMS all seem to succeed.

@zyguan
Copy link
Contributor Author

zyguan commented May 14, 2022

Whether the blue part will cause the leak is still unclear, so we need to continue to observe the next daily test report.

Does the memory leak still exist in the latest test? I see that the sqllogic tests on TCMS all seem to succeed.

No, no OOM recently. It’s ok now.

@zyguan zyguan closed this as completed May 14, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 labels Jun 21, 2022
@seiya-annie seiya-annie removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Jun 21, 2022
@seiya-annie seiya-annie removed may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major sig/diagnosis SIG: Diagnosis type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants