Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA RACE on the compactRequestMocker.receivedRequestsOfAddr #34795

Closed
hawkingrei opened this issue May 19, 2022 · 0 comments · Fixed by #34796
Closed

DATA RACE on the compactRequestMocker.receivedRequestsOfAddr #34795

hawkingrei opened this issue May 19, 2022 · 0 comments · Fixed by #34796
Assignees
@breezewish
Labels
component/test severity/minor type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

==================
WARNING: DATA RACE
Read at 0x00c02071f830 by goroutine 20:
  runtime.mapaccess1_faststr()
      /usr/local/go/src/runtime/map_faststr.go:13 +0x0
  github.com/pingcap/tidb/executor_test.(*compactRequestMocker).SendRequest()
      /go/tidb/executor/compact_table_test.go:704 +0xd7
  github.com/tikv/client-go/v2/internal/client.interceptedClient.SendRequest()
      /home/prow/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client_interceptor.go:42 +0x20b
  github.com/tikv/client-go/v2/internal/client.(*interceptedClient).SendRequest()
      <autogenerated>:1 +0xae
  github.com/tikv/client-go/v2/internal/client.reqCollapse.SendRequest()
      /home/prow/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client_collapse.go:74 +0x130
  github.com/tikv/client-go/v2/internal/client.(*reqCollapse).SendRequest()
      <autogenerated>:1 +0xae
  github.com/pingcap/tidb/executor.(*storeCompactTask).sendRequestWithRetry()
      /go/tidb/executor/compact_table.go:324 +0x1a7
  github.com/pingcap/tidb/executor.(*storeCompactTask).compactOnePhysicalTable()
      /go/tidb/executor/compact_table.go:234 +0x2d1
  github.com/pingcap/tidb/executor.(*storeCompactTask).work()
      /go/tidb/executor/compact_table.go:166 +0x6fc
  github.com/pingcap/tidb/executor.(*storeCompactTask).work-fm()
      <autogenerated>:1 +0x39
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/prow/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:74 +0x86
Previous write at 0x00c02071f830 by goroutine 91:
  runtime.mapassign_faststr()
      /usr/local/go/src/runtime/map_faststr.go:203 +0x0
  github.com/pingcap/tidb/executor_test.(*compactRequestMocker).SendRequest()
      /go/tidb/executor/compact_table_test.go:704 +0x11b
  github.com/tikv/client-go/v2/internal/client.interceptedClient.SendRequest()
      /home/prow/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client_interceptor.go:42 +0x20b
  github.com/tikv/client-go/v2/internal/client.(*interceptedClient).SendRequest()
      <autogenerated>:1 +0xae
  github.com/tikv/client-go/v2/internal/client.reqCollapse.SendRequest()
      /home/prow/go/pkg/mod/github.com/tikv/client-go/[email protected]/internal/client/client_collapse.go:74 +0x130
  github.com/tikv/client-go/v2/internal/client.(*reqCollapse).SendRequest()
      <autogenerated>:1 +0xae
  github.com/pingcap/tidb/executor.(*storeCompactTask).sendRequestWithRetry()
      /go/tidb/executor/compact_table.go:324 +0x1a7
  github.com/pingcap/tidb/executor.(*storeCompactTask).compactOnePhysicalTable()
      /go/tidb/executor/compact_table.go:234 +0x2d1
  github.com/pingcap/tidb/executor.(*storeCompactTask).work()
      /go/tidb/executor/compact_table.go:166 +0x6fc
  github.com/pingcap/tidb/executor.(*storeCompactTask).work-fm()
      <autogenerated>:1 +0x39
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/prow/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:74 +0x86
Goroutine 20 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/prow/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:71 +0x12e
  github.com/pingcap/tidb/executor.(*CompactTableTiFlashExec).doCompact()
      /go/tidb/executor/compact_table.go:110 +0x4e6
  github.com/pingcap/tidb/executor.(*CompactTableTiFlashExec).Next()
      /go/tidb/executor/compact_table.go:82 +0x11a
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:319 +0x5af
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:665 +0x6a4
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:516 +0x29c
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:465 +0xfc9
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:2069 +0x6cb
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1938 +0xdba
  github.com/pingcap/tidb/testkit.(*TestKit).Exec()
      /go/tidb/testkit/testkit.go:214 +0x701
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      /go/tidb/testkit/testkit.go:88 +0x99
  github.com/pingcap/tidb/executor_test.TestCompactTableMultipleTiFlashWithError()
      /go/tidb/executor/compact_table_test.go:378 +0x725
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1486 +0x47
Goroutine 91 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/prow/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:71 +0x12e
  github.com/pingcap/tidb/executor.(*CompactTableTiFlashExec).doCompact()
      /go/tidb/executor/compact_table.go:110 +0x4e6
  github.com/pingcap/tidb/executor.(*CompactTableTiFlashExec).Next()
      /go/tidb/executor/compact_table.go:82 +0x11a
  github.com/pingcap/tidb/executor.Next()
      /go/tidb/executor/executor.go:319 +0x5af
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      /go/tidb/executor/adapter.go:665 +0x6a4
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      /go/tidb/executor/adapter.go:516 +0x29c
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      /go/tidb/executor/adapter.go:465 +0xfc9
  github.com/pingcap/tidb/session.runStmt()
      /go/tidb/session/session.go:2069 +0x6cb
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      /go/tidb/session/session.go:1938 +0xdba
  github.com/pingcap/tidb/testkit.(*TestKit).Exec()
      /go/tidb/testkit/testkit.go:214 +0x701
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      /go/tidb/testkit/testkit.go:88 +0x99
  github.com/pingcap/tidb/executor_test.TestCompactTableMultipleTiFlashWithError()
      /go/tidb/executor/compact_table_test.go:378 +0x725
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1486 +0x47
==================

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@breezewish breezewish

Labels
component/test severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix data race in the test mocker breezewish/tidb
2 participants
@breezewish @hawkingrei