Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generation for test cases' results in the planner/core/testdata package can be improved #35368

Closed
Reminiscent opened this issue Jun 14, 2022 · 0 comments · Fixed by #35369
Assignees
Labels
component/test sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@Reminiscent
Copy link
Contributor

Reminiscent commented Jun 14, 2022

Enhancement

Now, if we want to record the test cases' results in the planner/core/testdata package, we can use the argument --record when we run the test cases. But it will clear the other test cases' results which have been already recorded. So we should improve the generation for the test cases.

@Reminiscent Reminiscent added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner component/test labels Jun 14, 2022
@Reminiscent Reminiscent self-assigned this Jun 14, 2022
@Reminiscent Reminiscent changed the title The generation for test cases in the planner/core/testdata package can be improved The generation for test cases' results in the planner/core/testdata package can be improved Jun 14, 2022
Yisaer pushed a commit to Yisaer/tidb that referenced this issue Jun 17, 2022
)

close pingcap#35368

address the comment

Signed-off-by: yisaer <[email protected]>

address the comment

Signed-off-by: yisaer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant