CREATE partitioned table fails check for unsigned int column definition

[mjonss]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

create table t (id tinyint unsigned, idpart tinyint, i varchar(255)) partition by range (idpart) (partition p1 values less than (-1));

2. What did you expect to see? (Required)

mysql> create table t (id tinyint unsigned, idpart tinyint, i varchar(255)) partition by range (idpart) (partition p1 values less than (-1));
Query OK, 0 rows affected (0,03 sec)

3. What did you see instead (Required)

tidb> create table t (id tinyint unsigned, idpart tinyint, i varchar(255)) partition by range (idpart) (partition p1 values less than (-1));
ERROR 1563 (HY000): Partition constant is out of partition function domain

4. What is your TiDB version? (Required)

tidb_version(): Release Version: v6.2.0-alpha-230-g47a4f3a017
Edition: Community
Git Commit Hash: 47a4f3a017768dda0b9a826451486c5539bc8427
Git Branch: master
UTC Build Time: 2022-06-29 19:09:58
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
Store: unistore

[mjonss]

Issue is in the isColUnsigned function.

[ymkzpx]

/assign

[mjonss]

I don't think this is a major issue, maybe moderate. The issue is checking column names with strings.Contains(strings.ToLower(pi.Expr), col.Name.L) meaning if any other column is a substring of the partitioning column and is unsigned, the function will return true (that the partition column is unsigned) during CREATE/ALTER TABLE.