-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstable test TestSortSpillDisk #37058
Comments
I think I have found the reason why this test is unstable (and it seems to be a bug), but I'm not sure how to fix it. There are many unstable assertions in this test:
This test will fail, in the following situation:
Then it will have two partitions, with the second one in memory
Nearly the same reason, it could have one or two partitions, and we cannot tell whether the second one is in the memory or disk. While I was trying to fix this problem, I have one question: Why is only The |
I'll take a look at the fallback route. |
this case fail again
|
This pr refactors sort spill, the issue may have been fixed. |
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
https://prow.pingcap.net/view/gs/pingcapprow/logs/bazel_test_tidb/1557686819372404736
2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiDB version? (Required)
The text was updated successfully, but these errors were encountered: