Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression introduced by pr/36963 #37096

Closed
tiancaiamao opened this issue Aug 15, 2022 · 1 comment · Fixed by #37103
Closed

Performance regression introduced by pr/36963 #37096

tiancaiamao opened this issue Aug 15, 2022 · 1 comment · Fixed by #37103
Assignees

Comments

@tiancaiamao
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

image

See http://www.zenlife.tk:18081/alloc

2. What did you expect to see? (Required)

No regression

3. What did you see instead (Required)

Manual test, before and after the change:

cd session;
go test -run XXX -bench BenchmarkTableScan -benchmem
BenchmarkTableScan-16    	    6127	    195089 ns/op	   60804 B/op	     792 allocs/op
BenchmarkTableScan-16    	    5616	    196387 ns/op	   62716 B/op	     824 allocs/op

4. What is your TiDB version? (Required)

master

@tiancaiamao tiancaiamao added the type/bug The issue is confirmed as a bug. label Aug 15, 2022
@tiancaiamao
Copy link
Contributor Author

Ref #25754
Ref #36963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants