Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only create TemporaryTableAttachedInfoSchema if needed #37195

Closed
lcwangchao opened this issue Aug 18, 2022 · 0 comments · Fixed by #37196
Closed

Only create TemporaryTableAttachedInfoSchema if needed #37195

lcwangchao opened this issue Aug 18, 2022 · 0 comments · Fixed by #37196
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Aug 18, 2022 •
edited
Loading

Enhancement

TemporaryTableAttachedInfoSchema costs more cpu times than informationSchema.infoschema even if the local temporary tables is empty:

image

We can optimize it to only create TemporaryTableAttachedInfoSchema, TemporaryTableSnapshotInterceptor` if needed.
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Aug 18, 2022
@lcwangchao lcwangchao changed the title *: Only create TemporaryTableAttachedInfoSchema, TemporaryTableSnapshotInterceptor if needed Only create TemporaryTableAttachedInfoSchema, TemporaryTableSnapshotInterceptor if needed Aug 18, 2022
@lcwangchao lcwangchao mentioned this issue Aug 18, 2022
Merged
12 tasks
@lcwangchao lcwangchao changed the title Only create TemporaryTableAttachedInfoSchema, TemporaryTableSnapshotInterceptor if needed Only create TemporaryTableAttachedInfoSchema if needed Aug 18, 2022
ti-chi-bot pushed a commit that referenced this issue Aug 18, 2022
@lcwangchao
*: only create TemporaryTableAttachedInfoSchema if needed (#37196)
44f684e 
close #37195
@lcwangchao lcwangchao mentioned this issue Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: only create TemporaryTableAttachedInfoSchema if needed lcwangchao/tidb
1 participant
@lcwangchao