Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports FLASHBACK TO TIMESTAMP in TiDB #37197

Closed
15 of 20 tasks
Defined2014 opened this issue Aug 18, 2022 · 1 comment
Closed
15 of 20 tasks

Supports FLASHBACK TO TIMESTAMP in TiDB #37197

Defined2014 opened this issue Aug 18, 2022 · 1 comment
Labels
type/new-feature

Comments

@Defined2014
Copy link
Contributor

Defined2014 commented Aug 18, 2022 •
edited
Loading

Background

Some users want to flash back the whole cluster to a determined timestamp when there is a problem with the database like delete some important values etc. In TiDB we use MVCC to store the key values in TiKV which means we could easy to flash back it before gc complete. This issue is the tracking issue for flashback cluster feature.

Task

Docs

TiDB

  • privilege check, a user with SUPER permission can run this stmts
  • check TS
  • check ddl history, can't have ddl jobs during flashback
  • check tiflash node, can't do it with tiflash
  • forbid & restart processing new ddl job in queue
  • close & recover pd scheduling
  • close & recover gc
  • show/get flashback cluster progress state from TiKV
  • Refetch statistics from TiKV
  • forbiden cancel flashback job in some states.
  • Reset Auto ID (optional)
  • Add flashback to telemetry #38896
  • add gc_savepoint (optional)
  • add a system table gc_savepoint
  • support auto set savepoint by TiDB itself
  • add a map according to natural physical time (Unix timestamp) -> TSO to avoid TSO drifts

Client-go

  • TiDB provide key range and tso to client-go, then client-go sending requests to all Region leaders in the key range (Could reuse some mechanism in client-go now, like backoff/coprocessor etc.)
  • Forbid read/write request to specified region during flashback cluster
  • Need an interface to get progress of flashback cluster

TiKV

PD

  • Add an interface to add/delete gc_savepoint (optional)
@bb7133 bb7133 changed the title Supports flash back cluster in TiDB Supports FLASHBACK CLUSTER in TiDB Aug 18, 2022
@bb7133 bb7133 mentioned this issue Aug 24, 2022
Closed
@Defined2014 Defined2014 mentioned this issue Sep 1, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 1, 2022
@Defined2014
*: merge feature/flashback-cluster to master (#37529)
a04000c 
ref #37197
@JmPotato JmPotato mentioned this issue Sep 2, 2022
Merged
@HuSharp HuSharp mentioned this issue Sep 5, 2022
Merged
1 task
ti-chi-bot pushed a commit that referenced this issue Sep 6, 2022
@HuSharp
ddl: Check the ResolvedTS during the preparation. (#37607)
4a88efc 
ref #37197
@Defined2014 Defined2014 mentioned this issue Sep 29, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 30, 2022
@Defined2014
*: delete mInFlashbackCluster related codes (#38241)
8f18fce 
ref #37197
@Defined2014 Defined2014 mentioned this issue Oct 10, 2022
Merged
12 tasks
@Defined2014 Defined2014 changed the title Supports FLASHBACK CLUSTER in TiDB Supports FLASHBACK TO TIMESTAMP in TiDB Oct 19, 2022
@Oreoxmt Oreoxmt mentioned this issue Nov 1, 2022
Merged
13 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 4, 2022
@Defined2014
docs: add a proposal for flashback to timestamp (#38367)
0ab5231 
ref #37197
@Defined2014
Copy link
Contributor Author

No further plan right now, close it firstly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/new-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Defined2014