Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify column does not report warnings #41118

Closed
mjonss opened this issue Feb 6, 2023 · 2 comments
Closed

Modify column does not report warnings #41118

mjonss opened this issue Feb 6, 2023 · 2 comments
Assignees
@mjonss
Labels
severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@mjonss
Copy link
Contributor

mjonss commented Feb 6, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

See #24427 and #38669.

This issue is for v6.5 to connect a possible backport of the fix, #38738 into the 6.5 release.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@mjonss mjonss added the type/bug The issue is confirmed as a bug. label Feb 6, 2023
@mjonss mjonss mentioned this issue Feb 6, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 labels Feb 7, 2023
@seiya-annie seiya-annie added sig/sql-infra SIG: SQL Infra and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 labels Feb 7, 2023
ti-chi-bot pushed a commit that referenced this issue Apr 11, 2023
@mjonss
ddl: backport of (#38738) tidb_ddl_reorg commit conflicts (#41115)
cee7565 
ref #24427, ref #38669, close #41118
@mjonss
Copy link
Contributor Author

mjonss commented Oct 12, 2023

I just checked current release-6.5 6907b47 and #24427 is no longer present and #38669 does not exist, since modify column in a partitioned table is disabled.
Same with release-7.1 369d7bc and current master 14d3cb5.

So I am closing this.

@mjonss mjonss closed this as completed Oct 12, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Oct 12, 2023

I'm also removing the labels, affects-6.5 and affects-7.1, since they are no-longer affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjonss mjonss

Labels
severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mjonss @VelocityLight @wjhuang2016 @seiya-annie @ti-chi-bot