Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send on closed channel in the TestRandomFail #52069

Closed
Tracked by #41316
hawkingrei opened this issue Mar 25, 2024 · 1 comment · Fixed by #52076
Closed
Tracked by #41316

send on closed channel in the TestRandomFail #52069

hawkingrei opened this issue Mar 25, 2024 · 1 comment · Fixed by #52076
Labels
severity/moderate sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

 [2024/03/25 08:11:41.578 +00:00] [ERROR] [agg_util.go:55] ["parallel hash aggregation panicked"] [error="Intest panic: final worker is panicked before start"] [errorVerbose="Intest panic: final worker is panicked before start\ngithub.com/pingcap/tidb/pkg/util.GetRecoverError\n\tpkg/util/util.go:305\ngithub.com/pingcap/tidb/pkg/executor/aggregate.recoveryHashAgg\n\tpkg/executor/aggregate/agg_util.go:53\ngithub.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggFinalWorker).cleanup\n\tpkg/executor/aggregate/agg_hash_final_worker.go:252\nruntime.gopanic\n\tGOROOT/src/runtime/panic.go:920\ngithub.com/pingcap/tidb/pkg/executor/aggregate.intestBeforeFinalWorkerStart\n\tpkg/executor/aggregate/agg_hash_final_worker.go:263\ngithub.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggFinalWorker).run\n\tpkg/executor/aggregate/agg_hash_final_worker.go:234\nruntime.goexit\n\tsrc/runtime/asm_amd64.s:1650"] [stack="github.com/pingcap/tidb/pkg/executor/aggregate.recoveryHashAgg\n\tpkg/executor/aggregate/agg_util.go:55\ngithub.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggFinalWorker).cleanup\n\tpkg/executor/aggregate/agg_hash_final_worker.go:252\nruntime.gopanic\n\tGOROOT/src/runtime/panic.go:920\ngithub.com/pingcap/tidb/pkg/executor/aggregate.intestBeforeFinalWorkerStart\n\tpkg/executor/aggregate/agg_hash_final_worker.go:263\ngithub.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggFinalWorker).run\n\tpkg/executor/aggregate/agg_hash_final_worker.go:234"] [stack="github.com/pingcap/tidb/pkg/executor/aggregate.recoveryHashAgg\n\tpkg/executor/aggregate/agg_util.go:55\ngithub.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggFinalWorker).cleanup\n\tpkg/executor/aggregate/agg_hash_final_worker.go:252\nruntime.gopanic\n\tGOROOT/src/runtime/panic.go:920\ngithub.com/pingcap/tidb/pkg/executor/aggregate.intestBeforeFinalWorkerStart\n\tpkg/executor/aggregate/agg_hash_final_worker.go:263\ngithub.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggFinalWorker).run\n\tpkg/executor/aggregate/agg_hash_final_worker.go:234"]
panic: send on closed channel [recovered]
	panic: send on closed channel
goroutine 601 [running]:
github.com/pingcap/tidb/pkg/executor/aggregate.recoveryHashAgg(0xc00087db58?, {0x47b2c40, 0x6601a20})
	pkg/executor/aggregate/agg_util.go:54 +0x110
github.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggExec).fetchChildData.func1()
	pkg/executor/aggregate/agg_hash_executor.go:434 +0x86
panic({0x47b2c40?, 0x6601a20?})
	GOROOT/src/runtime/panic.go:920 +0x270
github.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggExec).fetchChildData(0xc000b6a000, {0x66334f0, 0x9d664a0}, 0xc0054625f0)
	pkg/executor/aggregate/agg_hash_executor.go:481 +0x4fe
created by github.com/pingcap/tidb/pkg/executor/aggregate.(*HashAggExec).prepare4ParallelExec in goroutine 90
	pkg/executor/aggregate/agg_hash_executor.go:545 +0x19a 

4. What is your TiDB version? (Required)

@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant