Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for the tests need --with-real-tikv command line arguments, use code to turn it on #55529

Open
lance6716 opened this issue Aug 20, 2024 · 5 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@lance6716
Copy link
Contributor

Enhancement

As title. I don't want to edit the IDE configuration to add --with-real-tikv.

@lance6716 lance6716 added type/enhancement The issue or PR belongs to an enhancement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 20, 2024
@Garvit-77
Copy link

@lance6716
if you don't mind i would like to give it a try
could you assign me this issue

@lance6716
Copy link
Contributor Author

/assign @Garvit-77

I have linked a PR for this issue, it has resolved at least a part of the problem. Please check if there is still something to be done, for example, some tests which need --with-real-tikv command line argument does not use realtikvtest.RunTestMain

@Garvit-77
Copy link

Hey @lance6716 do we have any communication channel(slack, mailing forum, etc) except the GitHub the issues Thread.

@lance6716
Copy link
Contributor Author

Hey @lance6716 do we have any communication channel(slack, mailing forum, etc) except the GitHub the issues Thread.

it's in the README. Personally I don't join these channels and I have email notification to receive your issue response. 😄

@Garvit-77
Copy link

for our communication do you mind if we use mail
please ping me on [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants