Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time_test failure #68

Closed
mtorromeo opened this issue Sep 8, 2015 · 5 comments
Closed

time_test failure #68

mtorromeo opened this issue Sep 8, 2015 · 5 comments
Labels
type/bug The issue is confirmed as a bug.

Comments

@mtorromeo
Copy link

Hi,
when running the tests I get a failure:

FAIL: time_test.go:292: testTimeSuite.TestCodec

time_test.go:305:
    c.Assert(t.String(), Not(Equals), t1.String())
... obtained string = "2010-10-10 10:11:11"
... expected string = "2010-10-10 10:11:11

I think the problem is that the tested timezone is equal to my local timezone while it is assumed to be different.

@siddontang
Copy link
Member

Hi @mtorromeo
can you tell me what's your timezone?

@mtorromeo
Copy link
Author

Europe/Rome which is equivalent to the tested Europe/Berlin.

@siddontang
Copy link
Member

got it.
We will fix it ASAP.

@qiuyesuifeng
Copy link
Member

fixed.

@mtorromeo u can update tidb and try again.
Thanks for your report.

@mtorromeo
Copy link
Author

Yep, it works now.
Thanks for the fast fix!

@qiuyesuifeng qiuyesuifeng added the type/bug The issue is confirmed as a bug. label Sep 8, 2015
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
* update tidb dependency

Signed-off-by: 5kbpers <[email protected]>

* re-generate go.sum

Signed-off-by: 5kbpers <[email protected]>

* update tidb

Signed-off-by: 5kbpers <[email protected]>
okJiang pushed a commit to okJiang/tidb that referenced this issue Oct 19, 2021
* Add dumpling chinese manual

* address comment

* address comment

* Update user-guide.md

* Update README.md

Co-authored-by: Ian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants