Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement aggregate functions under the new framework #6952

Closed
10 tasks done
zz-jason opened this issue Jul 2, 2018 · 7 comments
Closed
10 tasks done

implement aggregate functions under the new framework #6952

zz-jason opened this issue Jul 2, 2018 · 7 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Milestone

Comments

@zz-jason
Copy link
Member

zz-jason commented Jul 2, 2018

This PR #6852 introduced the new framework to execute aggregate functions. Now the rest work is to rewrite every aggregate function under this new framework. The aggregate functions need to rewrite are listed in executor/aggfuncs/builder.go, which are:

To rewrite a function, take #6951 as an example, you need to:

  1. implement the aggregate function in file executor/aggfuncs/func_xxx.go
  2. supplement the buildXXX() function for the corresponding aggregate function in executor/aggfuncs/builder.go
  3. put the implemented aggregate functions into the var code block in file executor/aggfuncs/aggfuncs.go for code navigation.

If you are going to rewrite one of the above aggregate functions, please firstly make a comment here to let other contributors know. Feel free to contribute 😁

@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. status/WIP good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/execution SIG execution labels Jul 2, 2018
@zz-jason zz-jason added this to the 2.1 milestone Jul 2, 2018
@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 3, 2018

I'm interested to rewrite COUNT and SUM function.

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Jul 3, 2018

Really thank you for your support. @Xuanwo
To make this issue be finished as soon as possible,
if possible, you may implement COUNT first,
and continue to work on SUM after the above work finished
if there is no one else who is working on SUM?

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 3, 2018

@XuHuaiyu OK, I will implement COUNT first.

@laidahe
Copy link
Contributor

laidahe commented Jul 11, 2018

I want to implement SUM.OK?

@zz-jason
Copy link
Member Author

@laidahe Sure, thanks for your participation!😁

@XuHuaiyu
Copy link
Contributor

hi, @laidahe friendly ping ^_^
Any problem you've got these days?
If you need any help, feel free to comment here.

@zz-jason
Copy link
Member Author

All the aggregate functions are implemented, close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants