executor: refine StreamAggExec when child is empty #7002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gg_defaultval Conflicts: executor/aggregate.go
|
add a test that uses the new framework? |
zz-jason
added
type/enhancement
|
/run-all-tests |
|
LGTM |
|
PTAL @winoros |
|
@XuHuaiyu sqllogical test failed. |
|
/run-common-test |
zhexuany
reviewed
Jul 6, 2018
| return errors.Trace(err) | ||
| } | ||
| if !e.isChildReturnEmpty { | ||
| err = e.appendResult2Chunk(chk) |
There was a problem hiding this comment.
Why don't check the value of err here? If you have any particular reason to do so, is it better you add it here?
There was a problem hiding this comment.
err is checked in line 892
|
@XuHuaiyu any update? |
…gg_defaultval :q!
… into streamagg_defaultval :q!
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
zz-jason
reviewed
Jul 11, 2018
expression/aggregation/descriptor.go
Outdated
| // According to MySQL, DefaultValue of the aggregation function can be tested as the following sql: | ||
| // | ||
| // e.g. | ||
| // mysql> create table t(a int); |
There was a problem hiding this comment.
Can we simplify the comment? This format is not very formal 😂
There was a problem hiding this comment.
ok, I'll have a try
… into streamagg_defaultval :Q!
zz-jason
reviewed
Jul 11, 2018
expression/aggregation/descriptor.go
Outdated
| // +------+--------+--------+----------+------------+-----------+----------------------+--------+--------+-----------------+ | ||
| // | NULL | NULL | NULL | 0 | 0 | 0 | 18446744073709551615 | NULL | NULL | NULL | | ||
| // +------+--------+--------+----------+------------+-----------+----------------------+--------+--------+-----------------+ | ||
| func (a *AggFuncDesc) GetDefaultValue() (v types.Datum) { |
There was a problem hiding this comment.
Can this function be moved to the Aggregation interface, it seems like belonging to the execution layer.
|
PTAL @winoros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
This PR refines the StreamAgg process when ChildExec returns empty.
This processing logic can be used both in the old and new evaluation framework.
What are the type of the changes (mandatory)?
The currently defined types are listed below, please pick one of the types for this PR by removing the others:
How has this PR been tested (mandatory)?
the existing tests
Does this PR affect documentation (docs/docs-cn) update? (optional)
no
Refer to a related PR or issue link (optional)
#6952
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)