Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser.y: Ambiguous grammar #73

Closed
cznic opened this issue Sep 8, 2015 · 2 comments
Closed

parser.y: Ambiguous grammar #73

cznic opened this issue Sep 8, 2015 · 2 comments
Assignees
@shenli

Comments

@cznic
Copy link

cznic commented Sep 8, 2015

It seems that parser.y has several shift/reduce and reduce/reduce conflicts.

S/R conflicts are sometimes expected and/or acceptable, but I don't think this applies in this case. R/R conflicts, on the other hand, are almost never okay.

The current state of the grammar with all of the conflicts means that there are valid sentences, part of the intended-to-parse language, which will parse incorrectly or not at all because the grammar is ambiguous and does not reflect the proper language.

I suggest to get rid of all conflicts in parser.y and, above that, perhaps use the -cr goyacc flag to verify reducibility of all grammar productions.
@qiuyesuifeng
Copy link
Member

@shenli PTAL.
Thanks for your suggestion, and thank u for your awesome job again :)

coocood added a commit that referenced this issue Sep 9, 2015
@coocood
parser: resolve reduce/reduce conflicts
78c201e 
Resolved all the reduce/reduce conflicts except for 1

Fixes issue #73
@coocood coocood mentioned this issue Sep 9, 2015
Merged
@cznic cznic mentioned this issue Sep 11, 2015
Closed
@coocood
Copy link
Member

coocood commented Sep 14, 2015

resolved by final PR #122

@coocood coocood closed this as completed Sep 14, 2015
@crazycs520 crazycs520 mentioned this issue Nov 24, 2018
Merged
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
@overvenus
Restore override backupmeta path (pingcap#73)
428c603 
* test restore backup after changing its path

Signed-off-by: Neil Shen <[email protected]>

* restore: override backupmeta path by storage path

Signed-off-by: Neil Shen <[email protected]>
xhebox pushed a commit to xhebox/tidb that referenced this issue Sep 28, 2021
@feloxx
[parser] parser: implement Restore for TableName (pingcap#73)
1e4594d
xhebox pushed a commit to xhebox/tidb that referenced this issue Oct 8, 2021
@feloxx @xhebox
[parser] parser: implement Restore for TableName (pingcap#73)
68afb94
ti-chi-bot pushed a commit that referenced this issue Oct 9, 2021
@feloxx @ti-chi-bot
[parser] parser: implement Restore for TableName (#73)
1dc030a
Defined2014 added a commit to Defined2014/tidb that referenced this issue Apr 28, 2022
@Defined2014
ddl: support multi-schema change for alter column (pingcap#73)
619f939
iosmanthus pushed a commit to iosmanthus/tidb that referenced this issue Oct 31, 2022
@ystaticy
Fix GetGCSafePoint for test case TestRecoverTableByJobID (pingcap#73)
9267a2d 
* fix TestConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shenli shenli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cznic @coocood @shenli @qiuyesuifeng