Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some errors which should be checked are ignored #8779

Closed
qw4990 opened this issue Dec 24, 2018 · 2 comments
Closed

some errors which should be checked are ignored #8779

qw4990 opened this issue Dec 24, 2018 · 2 comments

Comments

@qw4990
Copy link
Contributor

qw4990 commented Dec 24, 2018

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.

Some errors which should be checked are ignored, which may leads some bugs;

These errors are in this report (search key word "assignment to err" in this page);

  1. What did you expect to see?

These errors should be checked;

  1. What did you see instead?

These errors are ignored;

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

Release Version: v2.1.0-rc.3-354-g062267674
Git Commit Hash: 0622676
Git Branch: ignored_err
UTC Build Time: 2018-12-24 02:36:24
GoVersion: go version go1.11.3 darwin/amd64
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-ff3dd160846b7d1aed9079c389fc188f7f5ea13e
Check Table Before Drop: false

@shenli
Copy link
Member

shenli commented Dec 24, 2018

@qw4990 This PR will fix some of the ignored errors in TiDB.

@zimulala
Copy link
Contributor

@qw4990
That PR is merged. If there are still problems, you can reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants