*: add the error check #8770
Merged
*: add the error check #8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwebs
reviewed
Dec 21, 2018
| @@ -1083,6 +1083,9 @@ func (e *MaxOneRowExec) Next(ctx context.Context, chk *chunk.Chunk) error { | |||
|
|
|||
| childChunk := e.children[0].newFirstChunk() | |||
| err = e.children[0].Next(ctx, childChunk) | |||
| if err != nil { | |||
| return errors.Trace(err) | |||
| } | |||
There was a problem hiding this comment.
So that was an ignored error. A good demonstration of using the error check.
|
3 ignored errors! Thanks, LGTM, would love to have this running in the CI. |
|
LGTM |
winkyao
approved these changes
Dec 23, 2018
|
/run-all-tests |
|
@zimulala We need to cherry-pick this to the release branches. |
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Dec 25, 2018
jackysp
pushed a commit
that referenced
this pull request
Dec 25, 2018
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Dec 25, 2018
ngaut
pushed a commit
that referenced
this pull request
Dec 25, 2018
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
tiancaiamao
added a commit
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add the error check
What is changed and how it works?
Return the error
Check the error information
Check List
Tests
Code changes
Side effects
Related changes
This change is