Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix incorrect time fraction parsing method #10001

Merged

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

fix issue #9734
tidb don't support date time format like "2019.01.01"

What is changed and how it works?

git cherry-pick #9933

Check List

Tests

  • Unit test

@zz-jason zz-jason requested a review from XuHuaiyu April 2, 2019 11:39
@zz-jason
Copy link
Member

zz-jason commented Apr 2, 2019

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. component/expression labels Apr 2, 2019
@zz-jason
Copy link
Member

zz-jason commented Apr 2, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2019
@zz-jason zz-jason merged commit e2a2cc4 into pingcap:release-2.1 Apr 4, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/cherry-pick-datetime branch April 4, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants