Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: support debug PB in client. #10038

Merged
merged 11 commits into from
Apr 4, 2019
Merged

store/tikv: support debug PB in client. #10038

merged 11 commits into from
Apr 4, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

A sub PR for fast analyze. Reference: #9973

What is changed and how it works?

Just add DebugPB.Client in tikv.client.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to be included in the release note

@lzmhhh123 lzmhhh123 mentioned this pull request Apr 4, 2019
Closed
@codecov
Copy link

codecov bot commented Apr 4, 2019 •
edited
Loading

Codecov Report

Merging #10038 into master will decrease coverage by 0.0049%.
The diff coverage is 13.0434%.

@@               Coverage Diff               @@
##             master     #10038       +/-   ##
===============================================
- Coverage   77.6767%   77.6717%   -0.005%     
===============================================
  Files           404        404               
  Lines         81919      81874       -45     
===============================================
- Hits          63632      63593       -39     
- Misses        13577      13585        +8     
+ Partials       4710       4696       -14

alivxxx
alivxxx reviewed Apr 4, 2019
View reviewed changes
store/tikv/tikvrpc/tikvrpc.go Outdated Show resolved Hide resolved
store/tikv/tikvrpc/tikvrpc.go Outdated Show resolved Hide resolved
alivxxx
alivxxx reviewed Apr 4, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 4, 2019
zz-jason
zz-jason reviewed Apr 4, 2019
View reviewed changes
store/tikv/client.go Outdated Show resolved Hide resolved
store/tikv/tikvrpc/tikvrpc.go Outdated Show resolved Hide resolved
@zz-jason
Copy link
Member

zz-jason commented Apr 4, 2019

/run-all-tests

@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@alivxxx
Copy link
Contributor

alivxxx commented Apr 4, 2019

/run-all-tests

zz-jason
zz-jason reviewed Apr 4, 2019
View reviewed changes
store/tikv/client.go Outdated Show resolved Hide resolved
store/tikv/tikvrpc/tikvrpc.go Outdated Show resolved Hide resolved
zz-jason
zz-jason approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2019
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@zz-jason zz-jason merged commit e6a5070 into pingcap:master Apr 4, 2019
@lzmhhh123 lzmhhh123 deleted the dev/debug_PB_tikv_client branch July 24, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/tikv status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzmhhh123 @zz-jason @alivxxx