-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: ddl-owner try to use memory infoSchema to check first #10170
Merged
tiancaiamao
merged 12 commits into
pingcap:master
from
crazycs520:ddl-owner-try-use-memory-info
Apr 23, 2019
Merged
ddl: ddl-owner try to use memory infoSchema to check first #10170
tiancaiamao
merged 12 commits into
pingcap:master
from
crazycs520:ddl-owner-try-use-memory-info
Apr 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
added
component/DDL-need-LGT3
type/enhancement
The issue or PR belongs to an enhancement.
labels
Apr 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #10170 +/- ##
================================================
+ Coverage 77.9363% 77.9531% +0.0167%
================================================
Files 407 407
Lines 83463 83531 +68
================================================
+ Hits 65048 65115 +67
+ Misses 13588 13584 -4
- Partials 4827 4832 +5 |
/run-all-tests |
winkyao
reviewed
Apr 16, 2019
…azycs520/tidb into ddl-owner-try-use-memory-info
winkyao
reviewed
Apr 17, 2019
winkyao
reviewed
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
ngaut
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
component/DDL-need-LGT3
labels
Apr 19, 2019
LGTM |
tiancaiamao
approved these changes
Apr 23, 2019
tiancaiamao
added
status/LGT3
The PR has already had 3 LGTM.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/LGT3
The PR has already had 3 LGTM.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make ddl-owner try to use memory infoschema to check first if the owner tidb-server already has loaded the latest schema.
Here is a simple test, There are 11394 tables in test20.
Deploy 1 tidb, 1 pd, 1 tikv.
create table
Before, spend 0.37s,
checkTableNotExists
spend 0.34sIn this PR: spend 0.07s,
checkTableNotExists
spend 267us.Create database
There are 18500 databases already in TiDB.
Before: spend 0.32S, and checkSchemaExist spend 250ms.
In this PR: 0.08s, checkSchemaExist spend 1 ms.
What is changed and how it works?
Change
checkTableNotExists
function.Check List
Tests
Code changes
Related changes