executor: ignore overflow error when construct inner key #10244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
changed the title
|
/run-all-tests |
shenli
reviewed
Apr 24, 2019
winoros
reviewed
Apr 24, 2019
|
/run-all-tests |
alivxxx
added
status/LGT2
Codecov Report
@@ Coverage Diff @@
## master #10244 +/- ##
===============================================
+ Coverage 77.8326% 77.8447% +0.012%
===============================================
Files 410 410
Lines 85017 84991 -26
===============================================
- Hits 66171 66161 -10
+ Misses 13902 13891 -11
+ Partials 4944 4939 -5 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #10244 +/- ##
===============================================
+ Coverage 77.8326% 77.8447% +0.012%
===============================================
Files 410 410
Lines 85017 84991 -26
===============================================
- Hits 66171 66161 -10
+ Misses 13902 13891 -11
+ Partials 4944 4939 -5 |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Apr 29, 2019
zz-jason
pushed a commit
that referenced
this pull request
Apr 29, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the outer join key of index join is not the same type as inner side, we may meet overflows error when constructing the inner join key, and it may raise errors to the client.
What is changed and how it works?
Ignore the overflow error when constructing the inner join key.
Check List
Tests
Code changes
Side effects
Related changes