*: add more cop task and memory info to slow_query table #10264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb7133
reviewed
Apr 25, 2019
infoschema/slow_log.go
Outdated
| p90ProcessTime float64 | ||
| maxProcessTime float64 | ||
| maxProcessAddress string | ||
| AvgWaitTime float64 |
There was a problem hiding this comment.
Suggested change
| AvgWaitTime float64 | |
| avgWaitTime float64 |
ditto for variables below
|
/rebuild |
|
/run-all-tests |
|
/rebuild |
1 similar comment
|
/rebuild |
|
/run-all-tests |
|
/rebuild |
|
LGTM |
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
|
/run-all-tests |
|
@crazycs520 please fix ci |
|
/rebuild |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10264 +/- ##
===============================================
- Coverage 77.8227% 77.8197% -0.003%
===============================================
Files 410 410
Lines 84316 84368 +52
===============================================
+ Hits 65617 65655 +38
- Misses 13805 13813 +8
- Partials 4894 4900 +6 |
bb7133
approved these changes
Apr 26, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Apr 30, 2019
zz-jason
pushed a commit
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
slow_querytable info and chage slow log parser to parser more field.Check List
Tests
Code changes
Side effects
Related changes