kv: remove the useless field of snapshot
#10276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10276 +/- ##
================================================
- Coverage 77.6992% 77.6727% -0.0265%
================================================
Files 411 411
Lines 85441 85389 -52
================================================
- Hits 66387 66324 -63
- Misses 14095 14105 +10
- Partials 4959 4960 +1 |
|
/run-all-tests |
ngaut
reviewed
Apr 26, 2019
| @@ -80,7 +79,6 @@ type unionStore struct { | |||
| func NewUnionStore(snapshot Snapshot) UnionStore { | |||
There was a problem hiding this comment.
Can you remove the argument of the function?
There was a problem hiding this comment.
It is used on line82.
|
PTAL @ngaut @tiancaiamao |
|
LGTM |
tiancaiamao
approved these changes
May 5, 2019
tiancaiamao
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
snapshotisn't being used.What is changed and how it works?
Remove the useless field in kv.
Check List
Tests