executor: fix IsPointGet judgment condition (#10278) #10304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix IsPointGet judgment condition
tiancaiamao
added
type/bugfix
|
Please fix CI. |
coocood
approved these changes
Apr 30, 2019
zz-jason
reviewed
Apr 30, 2019
| @@ -424,9 +424,6 @@ func IsPointGetWithPKOrUniqueKeyByAutoCommit(ctx sessionctx.Context, p plan.Plan | |||
| case *plan.PhysicalIndexReader: | |||
| indexScan := v.IndexPlans[0].(*plan.PhysicalIndexScan) | |||
| return indexScan.IsPointGetByUniqueKey(ctx.GetSessionVars().StmtCtx), nil | |||
| case *plan.PhysicalIndexLookUpReader: | |||
There was a problem hiding this comment.
index lookup is not allowed to use point get?
There was a problem hiding this comment.
It's more like a workaround other than a bugfix ..
There was a problem hiding this comment.
This point get is not point get executor, it's using MaxTS.
There was a problem hiding this comment.
It's a bugfix... maybe the function name is a bit confusing...
index lookup is not allowed to use max ts and this function checks whether to use max ts
https://github.com/tiancaiamao/tidb/blob/ab1abb1938782f4bd69d15650489f9074e26ade6/executor/adapter.go#L312
@zz-jason
|
merged, but no test... |
jackysp
added a commit
that referenced
this pull request
Apr 30, 2019
|
Yes, no test @jackysp
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix IsPointGet judgment condition
What is changed and how it works?
Cherry pick from #10278
(only the fix part, because the master branch evolves and differ from the release-2.0 branch)