Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: fix privilege check for update (#10281) #10326

Merged
merged 2 commits into from
Apr 30, 2019
Merged

planner/core: fix privilege check for update (#10281) #10326

merged 2 commits into from
Apr 30, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry pick #10281

@tiancaiamao
Copy link
Contributor Author

PTAL @zimulala @winkyao

zimulala
zimulala reviewed Apr 30, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2019
eurekaka
eurekaka approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 30, 2019
@jackysp jackysp merged commit c089bb9 into pingcap:release-2.1 Apr 30, 2019
@tiancaiamao tiancaiamao deleted the fix-update-privilege branch May 26, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
component/privilege status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @eurekaka @zimulala @jackysp