expression: fix cast(-num as datetime) to return null instead of error
#10368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
type/compatibility
type/bugfix
qw4990
commented
May 6, 2019
| {0, types.NewIntDatum(0), types.KindInt64, "0"}, | ||
| {0, types.NewIntDatum(-1), types.KindInt64, "0"}, | ||
| {0, types.NewIntDatum(12345), types.KindInt64, "0"}, | ||
| //{0, types.NewIntDatum(0), types.KindInt64, "0"}, |
There was a problem hiding this comment.
This is another bug(#10361) and I will fix it by another PR.
qw4990
commented
May 6, 2019
| result.Check(testkit.Rows("0")) | ||
| result = tk.MustQuery("SELECT UNIX_TIMESTAMP(12345);") | ||
| result.Check(testkit.Rows("0")) | ||
| //result = tk.MustQuery("SELECT UNIX_TIMESTAMP(-1);") |
There was a problem hiding this comment.
This is another bug(#10361) and I will fix it by another PR.
Codecov Report
@@ Coverage Diff @@
## master #10368 +/- ##
================================================
- Coverage 77.3669% 77.3454% -0.0215%
================================================
Files 412 412
Lines 85702 85687 -15
================================================
- Hits 66305 66275 -30
- Misses 14363 14383 +20
+ Partials 5034 5029 -5 |
30 tasks
|
/run-all-tests |
XuHuaiyu
changed the title
cast is not compatible with MySQLcast(-num as datetime) to return null instead of error
|
/run-all-tests |
alivxxx
added
status/LGT2
|
/run-all-tests |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Jun 4, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9769
What is changed and how it works?
Call
handleInvalidTimeErrorto handle errors.Check List
Tests