Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: should handle virtual columns when fetching duplicate rows in batchChecker (#10370) #10385

Merged
merged 2 commits into from
May 9, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented May 8, 2019

What problem does this PR solve?

Cherry-pick #10370 to release 2.1.

@jackysp jackysp added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels May 8, 2019
@jackysp
Copy link
Member Author

jackysp commented May 9, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 9, 2019
@zz-jason zz-jason merged commit 2766837 into pingcap:release-2.1 May 9, 2019
@jackysp jackysp deleted the fix_gen_batch_2.1 branch May 29, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants