Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid YEAR string is not compatible with Mysql #10493

Merged
merged 3 commits into from
May 17, 2019
Merged

fix invalid YEAR string is not compatible with Mysql #10493

merged 3 commits into from
May 17, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 15, 2019

cherry-pick for #9856.

winoros
winoros reviewed May 15, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qw4990
Copy link
Contributor Author

qw4990 commented May 15, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 requested review from XuHuaiyu and alivxxx May 16, 2019 02:41
alivxxx
alivxxx approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 6a4e14c into pingcap:release-2.1 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@alivxxx alivxxx alivxxx approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @winoros @alivxxx @zz-jason @b41sh