Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: RANGE frame can have no ORDER BY clause #10496

Merged
merged 3 commits into from
May 17, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented May 15, 2019

What problem does this PR solve?

fix #10494

What is changed and how it works?

Check whether there's a ORDER BY clause.

Check List

Tests

  • Unit test

@winoros winoros added type/bugfix This PR fixes a bug. sig/execution SIG execution labels May 15, 2019
@winoros winoros changed the title executor: RANGE frame can have no ORDER BY clause executor: RANGE frame can have no ORDER BY clause May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #10496 into master will increase coverage by 0.0079%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master     #10496        +/-   ##
================================================
+ Coverage   77.2761%   77.2841%   +0.0079%     
================================================
  Files           413        413                
  Lines         86966      86957         -9     
================================================
  Hits          67204      67204                
+ Misses        14601      14591        -10     
- Partials       5161       5162         +1

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx
Copy link
Contributor

alivxxx commented May 16, 2019

/run-all-tests

@winoros
Copy link
Member Author

winoros commented May 16, 2019

/run-integration-common-test
/run-sqllogic-test
/run-unit-test

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label May 17, 2019
@zz-jason zz-jason merged commit 8ec79be into pingcap:master May 17, 2019
@winoros winoros deleted the range-frame-no-order branch June 5, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RANGE frame clause in window function not alway needs a ORDER clause
4 participants