Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: reset groupChecker for StreamAggExec when Close (#10615) #10670

Merged
merged 2 commits into from
May 31, 2019
Merged

executor: reset groupChecker for StreamAggExec when Close (#10615) #10670

merged 2 commits into from
May 31, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #10615

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels May 31, 2019
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

alivxxx
alivxxx reviewed May 31, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2019
zz-jason
zz-jason approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2019
@zz-jason zz-jason merged commit babf93f into pingcap:release-2.1 May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @zz-jason @alivxxx